Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions modyfing RTPSender out of PeerConnection #75

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Feb 21, 2024

No description provided.

@LVala LVala self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Merging #75 (c6d3d52) into master (f96e563) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   88.41%   88.43%   +0.02%     
==========================================
  Files          29       29              
  Lines        1303     1306       +3     
==========================================
+ Hits         1152     1155       +3     
  Misses        151      151              
Files Coverage Δ
lib/ex_webrtc/peer_connection.ex 87.52% <100.00%> (+0.43%) ⬆️
lib/ex_webrtc/rtp_transceiver.ex 94.05% <76.47%> (-3.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96e563...c6d3d52. Read the comment docs.

@LVala LVala requested a review from mickel8 February 21, 2024 11:00
@LVala LVala merged commit 4e77274 into master Feb 21, 2024
4 checks passed
@LVala LVala deleted the move-sender-funcs branch February 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants