Add local/remote ICE candidates to current/pending description. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 89.03% 88.80% -0.23%
==========================================
Files 31 31
Lines 1395 1411 +16
==========================================
+ Hits 1242 1253 +11
- Misses 153 158 +5
Continue to review full report in Codecov by Sentry.
|
mickel8
approved these changes
Mar 6, 2024
lib/ex_webrtc/sdp_utils.ex
Outdated
| @@ -123,6 +123,13 @@ defmodule ExWebRTC.SDPUtils do | |||
| |> Enum.map(fn {"candidate", attr} -> attr end) | |||
| end | |||
|
|
|||
| @spec add_ice_candidates(ExSDP.t(), [binary()]) :: ExSDP.t() | |||
There was a problem hiding this comment.
To be consistent with get_ice_candidates?
Suggested change
| @spec add_ice_candidates(ExSDP.t(), [binary()]) :: ExSDP.t() | |
| @spec add_ice_candidates(ExSDP.t(), [String.t()]) :: ExSDP.t() |
| @@ -885,6 +885,27 @@ defmodule ExWebRTC.PeerConnectionTest do | |||
| end) | |||
| end | |||
|
|
|||
| describe "get_description" do | |||
There was a problem hiding this comment.
Nitpick: Could we put this after set_local_description test? I tried to match the order of tests with the order of functions in peer_connection.ex for easier navigation
Suggested change
| describe "get_description" do | |
| describe "get_local_description/1" do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to this changes, session description obtained from
pending_local_description()etc. will contain gathered/applied ICE candidates.Adresses #80