Allow for setting custom controlling process #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 88.96% 89.00% +0.03%
==========================================
Files 31 31
Lines 1387 1392 +5
==========================================
+ Hits 1234 1239 +5
Misses 153 153
Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
controlling-process
branch
from
5e020fc
to
2c3ac5a
Compare
mickel8
commented
Mar 5, 2024
| @@ -199,6 +199,19 @@ defmodule ExWebRTC.PeerConnectionTest do | |||
|
|
|||
| # API TESTS | |||
|
|
|||
| test "controlling process" do | |||
There was a problem hiding this comment.
Not sure if we want this test. I feel like it's pretty ugly 🤔
There was a problem hiding this comment.
I mean, if you have written it already...
mickel8
force-pushed
the
controlling-process
branch
from
2c3ac5a
to
7aa0890
Compare
LVala
approved these changes
Mar 6, 2024
| @@ -199,6 +199,19 @@ defmodule ExWebRTC.PeerConnectionTest do | |||
|
|
|||
| # API TESTS | |||
|
|
|||
| test "controlling process" do | |||
There was a problem hiding this comment.
I mean, if you have written it already...
Yup, it's needed to allow for spawning PeerConnection under supervision tree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.