Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with not-updating RTP header extensions on remote description #89

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Mar 12, 2024

Now, on set_remote_description, our PeerConnection's config is updated with RTP header extension IDs from the remote offer/answer. This PR fixes the issue of only updating either audio or video extensions, not both at the same time, which is a bug.

@LVala LVala requested a review from mickel8 March 12, 2024 15:25
@LVala LVala self-assigned this Mar 12, 2024
@LVala LVala merged commit 49dfba7 into master Mar 13, 2024
4 checks passed
@LVala LVala deleted the fix-rtp-hdr-exts branch March 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants