Generate NACKs and handle incoming RTX packets #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 88.74% 88.46% -0.28%
==========================================
Files 31 32 +1
Lines 1502 1561 +59
==========================================
+ Hits 1333 1381 +48
- Misses 169 180 +11
Continue to review full report in Codecov by Sentry.
|
mickel8
approved these changes
Mar 28, 2024
| @@ -104,20 +101,19 @@ defmodule ExWebRTC.RTPSender do | |||
| %ExRTP.Packet.Extension.SourceDescription{text: sender.mid} | |||
| |> ExRTP.Packet.Extension.SourceDescription.to_raw(mid_extmap.id) | |||
|
|
|||
| next_seq_num = sender.last_seq_num + 1 &&& 0xFFFF | |||
| packet = %{packet | payload_type: sender.pt, ssrc: sender.ssrc, sequence_number: next_seq_num} | |||
| packet = %{packet | payload_type: sender.pt, ssrc: sender.ssrc} | |||
| } = generator | ||
|
|
||
| delta = packet.sequence_number - last_sn | ||
| in_order? = delta < -@breakpoint or (delta > 0 and delta < @breakpoint) |
There was a problem hiding this comment.
Maybe we could move this to a separate RTP utils module
There was a problem hiding this comment.
I wouldn't, the amount of repetition is nearly non-existent and moving a single-line function to a separate module would make it harder to read, arguably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.