Allow add_ice_candidate when current_remote_description is not set
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 31 31
Lines 1503 1503
=======================================
Hits 1333 1333
Misses 170 170
Continue to review full report in Codecov by Sentry.
|
mickel8
approved these changes
Mar 21, 2024
lib/ex_webrtc/peer_connection.ex
Outdated
| def handle_call( | ||
| {:add_ice_candidate, _}, | ||
| _from, | ||
| %{current_remote_desc: crd, pending_remote_desc: prd} = state |
There was a problem hiding this comment.
Suggested change
| %{current_remote_desc: crd, pending_remote_desc: prd} = state | |
| %{current_remote_desc: nil, pending_remote_desc: nil} = state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that makes it impossible to use
add_ice_candidatewith only pending remote description.