Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incoming data before receiving an answer #95

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Mar 29, 2024

This PR makes it possible to receive data (e.g. DTLS handshake packets) from the remote peer before receiving an answer.

Now:

  1. Our ICE implementation allows data from unauthorised peer (so before we receive their credentials in an answer),
  2. DTLS requires remote's certs to perform the handshake.

DTLSTransport will now buffer packets received before receiving an answer and handle them after the transport has been initialised (so after answer has been set).

@LVala LVala self-assigned this Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #95 (5cbd8d7) into master (87b58f8) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   88.40%   88.49%   +0.09%     
==========================================
  Files          32       32              
  Lines        1561     1565       +4     
==========================================
+ Hits         1380     1385       +5     
+ Misses        181      180       -1     
Files Coverage Δ
lib/ex_webrtc/dtls_transport.ex 83.19% <100.00%> (+1.45%) ⬆️
lib/ex_webrtc/peer_connection.ex 85.32% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b58f8...5cbd8d7. Read the comment docs.

@LVala LVala marked this pull request as ready for review April 2, 2024 15:19
@LVala LVala requested a review from mickel8 April 2, 2024 15:19
@LVala LVala merged commit 8cbead2 into master Apr 3, 2024
3 checks passed
@LVala LVala deleted the handle-data-before-answer branch April 3, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants