fix: avoid float rounding in Money.to_string #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big numbers like
123_456_789_123_456_789_123_456_789_123_456_789
suffer from float rounding errors due to the way the conversion inMoney.to_string
is implemented.This PR aims to avoid such problems by performing the initial conversion and split using Integer and String functions only.
The following example (included in the new assertions I added) shows the bug.