Make Faker.Date.date_of_birth/1 with valid dates

[igas]

Right now dob can't be on 30 or 31. Suggestion is to introduce private function to_valid_day(date, month, year) and return maximum possible date, for example:

to_valid_day(31, 9, 2017) # => 30

In case of February we'll need to check for leap year.

[tobyhinloopen]

Isn't there some kind of common library that can represent a range of dates (EG a range from 17 years ago to 18 years ago) so we can just Enum.random it?

[lauraannwilliams]

Date Ranges are a 1.6 feature from the looks of things
https://github.com/elixir-lang/elixir/blob/741b6adbd8c4be1735dc9c605b8d5cdc7b73bc1a/lib/elixir/lib/calendar/date_range.ex#L1

Perhaps something like this https://medium.com/@natetsai/implementing-date-ranges-in-elixir-384460f3b7fa ?

or this seems very tidy https://stackoverflow.com/questions/30951318/how-to-create-a-stream-and-list-of-dates

[tobyhinloopen]

Fixed by MR #116

Enum.map(0..1000, fn i -> Faker.Date.date_of_birth(1).day end) 
|> Enum.reduce(%{}, fn day, acc -> Map.update(acc, day, 0, &(&1 + 1)) end)
%{1 => 40, 2 => 27, 3 => 35, 4 => 39, 5 => 25, 6 => 32, 7 => 21, 8 => 18,
  9 => 37, 10 => 28, 11 => 24, 12 => 28, 13 => 27, 14 => 30, 15 => 43, 16 => 26,
  17 => 31, 18 => 29, 19 => 36, 20 => 31, 21 => 31, 22 => 38, 23 => 21,
  24 => 41, 25 => 42, 26 => 32, 27 => 39, 28 => 36, 29 => 44, 30 => 29,
  31 => 10}