Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian versions of Name, Address, Color and Internet #215

Merged
merged 12 commits into from
Dec 27, 2018

Conversation

pmontrasio
Copy link
Contributor

I've added:

  • lib/faker/name/it.ex
  • lib/faker/address/it.ex
  • lib/faker/color/it.ex
  • lib/faker/internet/it.ex
  • links in USAGE.md to the Italian modules

See my comment to issue 123 about how I made doctests pass in my code #123 (comment)

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Glad to see Italian here 😀

lib/faker/name/it.ex Outdated Show resolved Hide resolved
@vbrazo
Copy link
Member

vbrazo commented Nov 14, 2018

You should also update the changelog.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

lib/faker/util.ex Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@igas igas merged commit 15edbc7 into elixirs:master Dec 27, 2018
@igas
Copy link
Member

igas commented Dec 27, 2018

Thank you @pmontrasio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants