Token Persistence #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A nice addition to this would be a PSR-16 (simple cache) adapter. If you want I can add it to the PR. |
|
Hello, Yes, a few month i was thinking about adding doctrine cache library. But now that we have PSR-16 adapter it would be a good addition to the library. if you don't mind, it would be great :) |
eljam
reviewed
Jun 3, 2019
| $this->assertTrue($tokenPersistence->hasToken()); | ||
| $this->assertEquals($tokenPersistence->restoreToken()->getToken(), $token->getToken()); | ||
|
|
||
| $tokenPersistence->deleteToken(); |
There was a problem hiding this comment.
Yep I was in a hurry last friday, I also forgot to stage the readme. I'll fix it tomorrow.
There was a problem hiding this comment.
Ok cool. Thank you for your contribution !
There was a problem hiding this comment.
I made the edits and squashed the changes in a single commit for cleaner history.
Better coverage Fix indentation. Update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I retrofited Sevastian Hübner work (@disasterdrop) on Token Persistence.
Extracted the changes from his hard fork, added documentation and test.
I credited him in PhpDoc
@authorfield.