Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of the languages in which the translation button is hidden #1247

Closed
3 tasks
baptiste0928 opened this issue Jan 17, 2023 · 8 comments · Fixed by #1371
Closed
3 tasks

Configuration of the languages in which the translation button is hidden #1247

baptiste0928 opened this issue Jan 17, 2023 · 8 comments · Fixed by #1371
Labels
s: pending triage Pending Triage

Comments

@baptiste0928
Copy link
Contributor

Clear and concise description of the problem

Actually, the translation button is shown for every toot in a different language than the browser language. We should be able to configure for which languages this button is shown.

Suggested solution

  • Hide translation button for toots in the same language as the UI.
  • Allow to configure untranslated languages in the settings.
  • Move translate button to the "more" menu for toots where it has been hidden, to translate anyway if needed.

Alternative

No response

Additional context

No response

@baptiste0928 baptiste0928 added the s: pending triage Pending Triage label Jan 17, 2023
@stackblitz
Copy link

stackblitz bot commented Jan 17, 2023

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@edimitchel
Copy link
Collaborator

Actually, your first point is already working but I think people don't use as much the publish language for his post, it's by default English. I open an issue about #1196 to dissociate display language and writing one which is not always the same.

@edimitchel
Copy link
Collaborator

Your second point could probably fixed by an option in the language preference, also, probably linked with #774 ?

@Alex0007
Copy link

Alex0007 commented Jan 19, 2023

+1 for additional languages that should not be translated.

If i remember correctly, current Mastodon implementation allows to select only 1 language (interface language), while people can know several languages and they don't want to see translate button for them

@edimitchel
Copy link
Collaborator

There is a publish language preference in mastodon we are planning to use in Elk.
So, publish language should take the precedence over the display if different.

@Alex0007
Copy link

There is a publish language preference in mastodon we are planning to use in Elk. So, publish language should take the precedence over the display if different.

I'm using English interface and english language for posts, while i'm native Russian speaker and don't want to translate those posts. With current Mastodon APIs – i can't achieve this

@edimitchel
Copy link
Collaborator

Good point, so an option of multiple selections of languages correctly understood?

@niklaswolf
Copy link
Contributor

I like the idea, too.
Additional to completely disabling translations (see #1358) there should be an option to disable translations for n languages from a list of all languages.

I'm willing to work on this feature and provide a PR later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: pending triage Pending Triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants