Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling translation for specific languages #1371

Merged
merged 10 commits into from
Jan 29, 2023

Conversation

niklaswolf
Copy link
Contributor

  • little refactoring: moved some logic into useTranslation composable
  • moved configurations regarding translations to the language section of the settings
  • added possibility to select different languages (currently supported for translation), for which the translation will be hidden in statuses
  • added actual logic to hide the translation if the status language should not be translated

closes #1247

@stackblitz
Copy link

stackblitz bot commented Jan 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 2e27c19
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63d652cf4a75520009bac502

@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 2e27c19
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63d652cf7df3680009260253
😎 Deploy Preview https://deploy-preview-1371--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

Nice!

This is how these settings look on Twitter. I like the positive vibe on these, asking you what you know instead of what translation to hide for the wording.
image

But I think we should merge this PR after you do the change you mentioned and then iterate. It is important we get the functionality to help users, and we can improve the settings UI later

@niklaswolf
Copy link
Contributor Author

@patak-dev I agree. Added the changes :)

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move forward to have the basic functionality and let others iterate on improving the UI.

@danielroe
Copy link
Member

Would you be able to resolve conflicts on this? 🙏

@niklaswolf
Copy link
Contributor Author

@danielroe conflicts are resolved now :)

@danielroe
Copy link
Member

Thank you ❤️

@danielroe danielroe changed the title feat: configuration to disable translation for specific languages feat: allow disabling translation for specific languages Jan 29, 2023
@danielroe danielroe merged commit b48b7f4 into elk-zone:main Jan 29, 2023
@niklaswolf niklaswolf deleted the translation-lang-selection branch January 29, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of the languages in which the translation button is hidden
3 participants