-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native): Improved layout in elk-native #1359
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This is awesome, thanks @piotrski! @JonasKruckenberg could you review this one too? |
Co-authored-by: patak <matias.capeletto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked on macOS and this looks great 👍🏻 much better than before. I also like that we now have a strategy for adding more platform specific styles later on, like a custom titlebar on Windows and Linux.
Should we just do a new |
I think we should do a release soon to have the translation preference |
Okay! Then just ping me once you release and we can coordinate a release like last time 👍🏻 |
Im now thinking we should do it Monday, better to avoid changing elk.zone during the weekend now that we have so many users. Feel free to release native before |
What did you think @piotrski? I guess this change is a rather big one and I would appreciate getting the release out asap, but maybe waiting for the proper release would be better (stability and fixes that might come in before monday?) |
@piotrski I think this PR affected the styles on Web, see the size of the right sidebar here and the extra padding between the left sidebar and the timeline. Would you review what happened here? |
@piotrski @JonasKruckenberg I pushed 2a836ed that reverts some of the changes to the default layout. I don't know how this affects the native styles, please follow up with a PR that keeps the current style in the web if you would like changes for the native wrapper. |
native:
andnative-mac:
. Styles for these variants will only be generated if theTAURI_PLATFORM
variable is properly set during the build process.Here are before and after screenshots:
650px:
1000px:
1200px:
1400px:
closes elk-zone/elk-native#44