feat: improve follows you grouping #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://elk.zone/fediverse.zachleat.com/@zachleat/109739539249687601 for context.
We got feedback that using a hard limit using the followers count was a bit awkward. We had already discussed something along these lines before and proposed using percentages relative to the user followers count. I think this wouldn't be ok either.
This PR changes the grouping algorithm to test in it in the wild in the next release.
It now orders the group according to who has a header first (giving priority to folks that did setup their account), and who has more followers second. Then it shows the first one of the group (if it has a header) as a big card, no matter how many followers it has. If only one remains and it has a header, it is also expanded as a big card. If not, the remaining are shown as a group of avatars in a single line.