Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add viewport header to enable/disable pinch to zoom in Safari #1590

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix(ui): add viewport header to enable/disable pinch to zoom in Safari #1590

merged 1 commit into from
Feb 3, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Feb 3, 2023

closes #1587

@stackblitz
Copy link

stackblitz bot commented Feb 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 3, 2023 •
edited

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit b17cb32
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63dccb8c626d9a0008cc146e

@netlify
Copy link

netlify bot commented Feb 3, 2023 •
edited

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit b17cb32
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63dccb8cf7b7460008b37e5a
😎 Deploy Preview https://deploy-preview-1590--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin changed the title fix(ui): add viewport header to pinch to zoom in Safari fix(ui): add viewport header to enable/disable pinch to zoom in Safari Feb 3, 2023
Shinigami92
Shinigami92 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works instantly, even in the settings page were you can toggle the flag on and off 👌

@userquin
Copy link
Member Author

userquin commented Feb 3, 2023

https://streamable.com/o8kf9s

@userquin userquin marked this pull request as ready for review February 3, 2023 09:02
@patak-dev
Copy link
Member

Awesome!

@patak-dev patak-dev merged commit a2fb458 into main Feb 3, 2023
@patak-dev patak-dev deleted the userquin/fix-pinch-to-zoom-safari branch February 3, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinch to zoom still enabled on PWA iOS even when setting disabled
3 participants
@userquin @patak-dev @Shinigami92