Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saving profile data breaks cache #1937

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

userquin
Copy link
Member

@userquin userquin commented Apr 1, 2023

We need to add @server to the acct account response and override account cache, check:

closes #1879

@stackblitz
Copy link

stackblitz bot commented Apr 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Apr 1, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 7cd014f
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6427f9d6a623190008ac9a4a

@netlify
Copy link

netlify bot commented Apr 1, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 7cd014f
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6427f9d60c353b0008ff7768
😎 Deploy Preview https://deploy-preview-1937--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense with the current way we are handling user accounts, but for future reference @patak@m.webtoo.ls isn't valid. It should be @patak@webtoo.ls. We have this issue across the app right now and we have discussed with @userquin before about possible solutions. It isn't an easy task to fix it though.

@patak-dev patak-dev merged commit f07d323 into main Apr 16, 2023
@patak-dev patak-dev deleted the userquin/fix-user-picker branch April 16, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile editor messes up User Picker
2 participants