fix: Handle failure when fetching user preferences #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for elk-docs canceled.
|
natsukagami
force-pushed
the
no-preferences-on-gts
branch
from
d522309
to
1f56a72
Compare
If fetching preferences fail, continue with no known preferences. Some servers (such as the current latest version of GoToSocial) has not implemented the `GET /preferences` endpoint. This API call is failing and causing the whole `fetchAccountInfo` function to throw, effectively logging the user out.
natsukagami
force-pushed
the
no-preferences-on-gts
branch
from
1f56a72
to
9230c3f
Compare
natsukagami
changed the title
patak-dev
approved these changes
May 5, 2023
There was a problem hiding this comment.
Looks good, sorry for the glitch in GoToSocial. We should have left the change in main.elk.zone for a bit longer (although I don't know how many GoToSocial users are in the main channel testing right now). Let's merge and do a quick release to avoid further issues
|
@natsukagami 0.9.5 includes this fix, thanks again! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fetching preferences fail, continue with no known preferences.
Some servers (such as the current latest version of GoToSocial)
has not implemented the
GET /preferencesendpoint. This API call is failingand causing the whole
fetchAccountInfofunction to throw,effectively logging the user out.
I've also contacted the GoToSocial guys to quickly write up an endpoint,
but this would be a quicker fix as opposed to all GtS users failing to log into
their instance from Elk (we get logged out immediately after authentication as of now).
Note that some of the preferences shown up in the API,
particularly
reading:expand:mediaandreading:expand:spoilersdoesn't seemto even have an endpoint where it can be set at the moment.
I don't know what is the standard for "show an error, that is probably not very important
to the user" in the codebase, so I just left a
console.warnfor now. Feel free to edit itto the standards.