Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: poll creation #2111

Merged
merged 7 commits into from
May 20, 2023
Merged

Conversation

JohnyTheCarrot
Copy link
Contributor

@JohnyTheCarrot JohnyTheCarrot commented May 20, 2023

A PR for the much requested poll creation feature! 🥳
Since this modifies the status creation process, it's probably best to do rigorous testing for bugs.

msedge_Zkx1lwylyQ.mp4

closes #1769
closes #1668

@stackblitz
Copy link

stackblitz bot commented May 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented May 20, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit d32691e
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6468a8313040ec000853dad8

@netlify
Copy link

netlify bot commented May 20, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit d32691e
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6468a83187699f0008f4cd68
😎 Deploy Preview https://deploy-preview-2111--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JohnyTheCarrot JohnyTheCarrot changed the title Feat/poll creation feat: poll creation May 20, 2023
@patak-dev
Copy link
Member

This is awesome! I like the UI for the poll options but I just played in mobile and only with icons it will be hard for people to understand. Maybe we should have the options as text plus icon checkboxes above the post toolbar.

@JohnyTheCarrot
Copy link
Contributor Author

Hmmm, I also don't know how this fairs with editing.

@JohnyTheCarrot
Copy link
Contributor Author

msedge_kiC5xBqTtV

@patak-dev how about this?

@patak-dev
Copy link
Member

Looks good, maybe the icons to the left to avoid the layout shift

@JohnyTheCarrot
Copy link
Contributor Author

Looks good, maybe the icons to the left to avoid the layout shift

Unsure what you mean

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that we could have the icon on the left for these two CommonCheckbox, but the layout shift will still be there. We could have the width of the pop over to be bigger so it stay the same when the text change.

It seems the polls options isn't preserved in the draft (if you go to other screen and then back or reload). And I think maybe we should force the poll to have at least two options? 🤔

But let's merge this and iterate! So we get some testing from folks in main.elk.zone for a bit.

@patak-dev patak-dev merged commit 1fda338 into elk-zone:main May 20, 2023
13 checks passed
toufali pushed a commit to MozillaSocial/elk that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating polls Editing a post with a poll results in the poll being deleted
2 participants