-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: poll creation #2111
feat: poll creation #2111
Conversation
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This is awesome! I like the UI for the poll options but I just played in mobile and only with icons it will be hard for people to understand. Maybe we should have the options as text plus icon checkboxes above the post toolbar. |
Hmmm, I also don't know how this fairs with editing. |
@patak-dev how about this? |
Looks good, maybe the icons to the left to avoid the layout shift |
Unsure what you mean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that we could have the icon on the left for these two CommonCheckbox, but the layout shift will still be there. We could have the width of the pop over to be bigger so it stay the same when the text change.
It seems the polls options isn't preserved in the draft (if you go to other screen and then back or reload). And I think maybe we should force the poll to have at least two options? 🤔
But let's merge this and iterate! So we get some testing from folks in main.elk.zone for a bit.
A PR for the much requested poll creation feature! 🥳
Since this modifies the status creation process, it's probably best to do rigorous testing for bugs.
msedge_Zkx1lwylyQ.mp4
closes #1769
closes #1668