Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report posts #2184

Merged
merged 6 commits into from
Jun 23, 2023
Merged

feat: Report posts #2184

merged 6 commits into from
Jun 23, 2023

Conversation

aaga
Copy link
Contributor

@aaga aaga commented Jun 22, 2023

Adds a modal dialog flow for reporting posts. Mostly mimics the stock Mastodon web app implementation.

Note: this PR rolls in the changes from an existing open PR for menu UI: #1673. If this PR is merged, #1673 can be closed as well.

@stackblitz
Copy link

stackblitz bot commented Jun 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit c498ca7
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64949b520cacc10008758288

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit c498ca7
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/64949b52b951cd0007ea424e
😎 Deploy Preview https://deploy-preview-2184--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

Looks good to me @aaga! And great to see Mozilla interested in Elk and in contributing.

I don't know how to properly test this one without reporting someone, so maybe we should merge so we get it deployed to https://main.elk.zone and let others use the reporting tool to check it out.

Something I think we could change before merging is making the dialog wider on desktop. The Next button was after the fold in some cases with the current width
image

aaga and others added 2 commits June 22, 2023 14:58
Co-authored-by: patak <matias.capeletto@gmail.com>
@aaga
Copy link
Contributor Author

aaga commented Jun 22, 2023

Thanks for the feedback @patak-dev. I increased the max-width of the dialog a bit; ultimately the number and length of server rules will determine how far down the Next button is, but hopefully this new width helps make things feel a little less cramped.

And yes, merging for testing on https://main.elk.zone sounds good!

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot better now! I'll approve it and leave some time for others to check it out. If we don't see other comments, we could merge tomorrow and test it for a bit on https://main.elk.zone.

@patak-dev patak-dev added p: 2-high Fix main branch c: parity Parity with Mastodon web app labels Jun 22, 2023
@patak-dev patak-dev merged commit 34aca66 into elk-zone:main Jun 23, 2023
14 checks passed
@aaga aaga deleted the feat/reporting branch August 9, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: parity Parity with Mastodon web app p: 2-high Fix main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants