Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): stop question mark propagation #2209

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix(ui): stop question mark propagation #2209

merged 1 commit into from
Jul 10, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Jul 8, 2023

closes #1910

@stackblitz
Copy link

stackblitz bot commented Jul 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jul 8, 2023 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit cdf8735
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64a977d1da277e00084154c1

@netlify
Copy link

netlify bot commented Jul 8, 2023 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit cdf8735
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/64a977d18398160008ad9ca8
😎 Deploy Preview https://deploy-preview-2209--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johnsonm
Copy link

johnsonm commented Jul 8, 2023 •
edited
Loading

This has resolved the problem for me at least on Firefox 114 and 115 on Linux and Chrome 114 on Linux.

patak-dev
patak-dev approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a more general solution if we later have other shortcuts, but let's merge this for now as this bug is affecting a lot of users.

@patak-dev patak-dev merged commit 2506c02 into main Jul 10, 2023
16 checks passed
@patak-dev patak-dev deleted the userquin/fix-question-mark-and-publish branch July 10, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compose a post with a question mark prompts shortcut modal on publish
3 participants
@userquin @johnsonm @patak-dev