New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add roles into account header and info #2265
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I don't know how well this will work out when there are many labels but let's get it merged and keep iterating once we get a good report.
Is it intentional that when there is no specific role, there is an empty box? I am assuming not. I've attached an image from Elk Canary. |
Maybe that user has a role that is an empty string? You could send a PR to guard against that. I don't see the empty box in https://main.elk.zone/ for any of the users I follow. |
Hmm, ok. I'll do a bit of testing and try and figure out why that's happened then. |
@iruldi, @EddiesTech is right, it seems there is an empty box when you hover over users, and also on the user switcher on the bottom left. PR welcome to fix this one if you have some time |
@patak-dev Thanks, I'll do that soon! |
Didn't know why it was showing up some times but now it should not be the case anymore and it's much better this way. PR: #2333 |
Add roles into account header and account info
Linked to issue: #2056
Added
AccountRoleIndicator
which is based onAccountBotIndicator
so it has the same design. I use the color and name of the Role object to display it on the profile.