Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add roles into account header and info #2265

Merged
merged 1 commit into from Jul 25, 2023

Conversation

iruldi
Copy link
Contributor

@iruldi iruldi commented Jul 25, 2023

Add roles into account header and account info

Linked to issue: #2056

Added AccountRoleIndicator which is based on AccountBotIndicator so it has the same design. I use the color and name of the Role object to display it on the profile.

Screenshot 2023-07-25 at 16 29 11 Screenshot 2023-07-25 at 16 29 21

@stackblitz
Copy link

stackblitz bot commented Jul 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 57e8545
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/64bfddde9a822d0008c94ba7
😎 Deploy Preview https://deploy-preview-2265--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 57e8545
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64bfddde42f51700081bb6e5

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't know how well this will work out when there are many labels but let's get it merged and keep iterating once we get a good report.

@patak-dev patak-dev merged commit 22a1388 into elk-zone:main Jul 25, 2023
14 checks passed
@iruldi iruldi mentioned this pull request Jul 25, 2023
@EddiesTech
Copy link
Contributor

EddiesTech commented Jul 28, 2023

Is it intentional that when there is no specific role, there is an empty box? I am assuming not. I've attached an image from Elk Canary.
@iruldi @patak-dev
Screenshot_20230728-135006

@patak-dev
Copy link
Member

Maybe that user has a role that is an empty string? You could send a PR to guard against that. I don't see the empty box in https://main.elk.zone/ for any of the users I follow.

@EddiesTech
Copy link
Contributor

Hmm, ok. I'll do a bit of testing and try and figure out why that's happened then.

@patak-dev
Copy link
Member

@iruldi, @EddiesTech is right, it seems there is an empty box when you hover over users, and also on the user switcher on the bottom left. PR welcome to fix this one if you have some time
image

@iruldi
Copy link
Contributor Author

iruldi commented Aug 12, 2023

@patak-dev Thanks, I'll do that soon!

@iruldi iruldi mentioned this pull request Aug 12, 2023
@iruldi
Copy link
Contributor Author

iruldi commented Aug 12, 2023

Didn't know why it was showing up some times but now it should not be the case anymore and it's much better this way.

PR: #2333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants