fix: profile header avatar being pushed lower on smaller devices #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
patak-dev
reviewed
Oct 9, 2023
components/account/AccountHeader.vue
Outdated
| @@ -115,7 +115,7 @@ const personalNoteMaxLength = 2000 | |||
| <div p4 mt--18 flex flex-col gap-4> | |||
| <div relative> | |||
| <div flex justify-between> | |||
| <button shrink-0 :class="{ 'rounded-full': !isSelf, 'squircle': isSelf }" p1 bg-base border-bg-base z-2 @click="previewAvatar"> | |||
| <button shrink-0 class="h-full" :class="{ 'rounded-full': !isSelf, 'squircle': isSelf }" p1 bg-base border-bg-base z-2 @click="previewAvatar"> | |||
There was a problem hiding this comment.
This can directly be h-full, no?
Suggested change
| <button shrink-0 class="h-full" :class="{ 'rounded-full': !isSelf, 'squircle': isSelf }" p1 bg-base border-bg-base z-2 @click="previewAvatar"> | |
| <button shrink-0 h-full :class="{ 'rounded-full': !isSelf, 'squircle': isSelf }" p1 bg-base border-bg-base z-2 @click="previewAvatar"> |
There was a problem hiding this comment.
Ah I forgot that was possible in this project, you're totally right
maybeanerd
force-pushed
the
fix-profile-header-avatar-being-pushed-lower-on-smaller-devices
branch
from
8890c73
to
4468dc0
Compare
patak-dev
approved these changes
Oct 9, 2023
maybeanerd
deleted the
fix-profile-header-avatar-being-pushed-lower-on-smaller-devices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue where on smaller devices the avatar was moved down, not aligning with the profile header anymore
an example of the issue can be seen here:
Fixed it looks like this:
to test the fix, you can take a look at any profile with header image and profile picture on a smaller screen ( when the profile buttons wrap around), the account I used is http://localhost:5314/bumscode.com/@tagesschau@ard.social on screen width 320px