Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2439 - endMessage in CommonPaginator #2441

Merged
merged 1 commit into from Oct 24, 2023
Merged

Conversation

ttntm
Copy link
Contributor

@ttntm ttntm commented Oct 24, 2023

This is a PR for #2439 that adds a check for items.length in CommonPaginator.vue before setting the endMessage displayed in the UI.

1+ entries show common.end_of_list now:

Screenshot from 2023-10-24 12-06-15

<= 0 entries show the endMessage defined by the parent component, i.e. common.no_bookmarks in TimelineBookmarks.vue:

Screenshot from 2023-10-24 12-06-23

@stackblitz
Copy link

stackblitz bot commented Oct 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 45cfd16
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/653798b09c84a30008cb05b4

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 45cfd16
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/653798b0a27540000883cdf8
😎 Deploy Preview https://deploy-preview-2441--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ttntm ttntm changed the title Fix for #2439 - endMessage in CommonPaginator fix: #2439 - endMessage in CommonPaginator Oct 24, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev added this pull request to the merge queue Oct 24, 2023
Merged via the queue into elk-zone:main with commit 5d09e7d Oct 24, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants