You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new rest API is quite nice (most of the changes in the PR are related to it). And the way streaming works also changed significantly. As far as I can tell, everything is working as expected (except for search, see neet/masto.js#1018. Pushing the PR as a draft until the fixes for are available as a new release).
We need to review types and logic in service-worker (@patak-dev I've sent you private DM in discord)
The line you shared in Discord seems ok after the upgrade as it is a direct call. It doesn't use masto. If you could check anyways that things looks good on the service-worker/pwa side after this PR, appreciated!
Search is fixed now. Tests are failing because of a type error on AbortSignal.timeout, but I think it may be an issue with Vitest? Node 18 should have that function
Search is fixed now. Tests are failing because of a type error on AbortSignal.timeout, but I think it may be an issue with Vitest? Node 18 should have that function
c: refactorPR that affects the runtime behavior, but doesn't add new features or fixes bugs
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patak-dev
added
the
c: refactor
Check out the migration guide to see what's new in masto.js v6
The new rest API is quite nice (most of the changes in the PR are related to it). And the way streaming works also changed significantly. As far as I can tell, everything is working as expected (except for search, see neet/masto.js#1018. Pushing the PR as a draft until the fixes for are available as a new release).