feat(ui): fetch account data on demand #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
|
Is the skeleton still working for you? I can't see it when I test the preview: https://deploy-preview-2632--elk-zone.netlify.app/ |
|
skeleton logic removed, only fetch on hover |
patak-dev
reviewed
Mar 4, 2024
| @@ -5,7 +5,7 @@ const { account } = defineProps<{ | |||
| account: mastodon.v1.Account | |||
| }>() | |||
|
|
|||
| const relationship = useRelationship(account) | |||
| const relationship = computed(() => account ? useRelationship(account).value : undefined) | |||
There was a problem hiding this comment.
I don't think we should call useRelationship inside a computed. I think you should extract useRelationship to an outside ref. If you don't want that ref (that changes once fetchRelationships() finished), then you could abstract a helper around requestedRelationships
There was a problem hiding this comment.
too many useRelationship usages to refactor it here: we should debounce the call
patak-dev
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
add status card skeleton when resolving the account dataThis will also prevent fetching account data of all accounts in the viewport while scrolling.
We can change the skeleton or switch to use an spinner loader.
Check this video https://streamable.com/4kk87e : added few seconds timeout to see the skeleton on first fetch (afterwards it is immediate)
/cc @patak-dev @shuuji3