fix: show loading spinner on follow button while fetching account relationship #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
changed the title
shuuji3
force-pushed
the
fix/follow-button-loading-spinner
branch
from
e6fa322
to
30403f7
Compare
patak-dev
reviewed
Mar 9, 2024
Comment on lines
16
to
20
| const isLoading = ref(false) | ||
|
|
||
| watchEffect(() => { | ||
| isLoading.value = relationship.value === undefined | ||
| }) |
There was a problem hiding this comment.
Could this be rewritten as:
Suggested change
| const isLoading = ref(false) | |
| watchEffect(() => { | |
| isLoading.value = relationship.value === undefined | |
| }) | |
| const isLoading = computed(() => relationship.value === undefined) |
?
There was a problem hiding this comment.
That's correct 👍🏻 and confirmed the change works as expected on local env.
|
Looks awesome 💯 |
Co-authored-by: patak <583075+patak-dev@users.noreply.github.com>
patak-dev
approved these changes
Mar 9, 2024
maybeanerd
pushed a commit
to maybeanerd/crab
that referenced
this pull request
Mar 11, 2024
…ationship (elk-zone#2667) Co-authored-by: patak <583075+patak-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2647
This PR makes the loading spinner shown while loading a follow relationship with an account so that we can avoid showing a different button label from the actual relationship. The difference is noticeable, especially when the loading time is long.
Screen recording
Before
Screen.Recording.2024-03-10.at.1.18.48.2.mp4
After
loading.mp4