-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent empty search keyword to send invalid request #2676
fix: prevent empty search keyword to send invalid request #2676
Conversation
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are really hard to spot. Maybe I should have used an automated tool 🫠
Thanks for fixing it!
Year, it's no surprise to miss one in the middle of logic like this 😄 I'm wondering why ESLint still cannot detect these refs even though we successfully upgraded ESLint configs by #2651 I also tried adding a specific rule for this (https://eslint.vuejs.org/rules/no-ref-as-operand.html) but it still fails to detect the usage without .value: https://github.com/elk-zone/elk/blob/9da77637b22d4ce294449f4ee6540d97645b2d8a/eslint.config.js ...
export default await antfu(
{
unocss: false,
vue: {
overrides: {
'vue/no-restricted-syntax': ['error', {
selector: 'VElement[name=\'a\']',
message: 'Use NuxtLink instead.',
}],
+ 'vue/no-ref-as-operand': 'error',
},
},
... |
@shuuji3 L62 needs also .value |
@userquin @patak-dev Yes, that's another one👍🏻 I also found a temporary workaround to enable this rule and found other ones too. I will send a PR to fix them together today. |
I wrote the workaround here: #2678 |
fix #2675
This was caused by another missing
.value
😅