Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix vue/no-ref-as-operand and vue/return-in-computed-property ESLint errors #2679

Merged

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Mar 11, 2024

see #2678 for how to temporarily enable some vue-related ESLint rules

Copy link

stackblitz bot commented Mar 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 6e57c16
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65eed4308169e7000853e690

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 6e57c16
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65eed430d66c520008c0b5e1
😎 Deploy Preview https://deploy-preview-2679--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3 shuuji3 force-pushed the fix/eslint-vue-no-ref-as-operand-errors branch from f94f340 to 6e57c16 Compare March 11, 2024 09:51
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is great! These would explain a lot of the bugs we are seeing. Sorry I missed all of them 😬
Let's merge and do a new release

@patak-dev patak-dev added this pull request to the merge queue Mar 11, 2024
Merged via the queue into elk-zone:main with commit 3b1a66c Mar 11, 2024
13 checks passed
@shuuji3 shuuji3 deleted the fix/eslint-vue-no-ref-as-operand-errors branch March 11, 2024 10:58
maybeanerd pushed a commit to maybeanerd/crab that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants