Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): media preview card is misaligned #2751

Merged
merged 1 commit into from Apr 5, 2024

Conversation

lazzzis
Copy link
Contributor

@lazzzis lazzzis commented Apr 4, 2024

Not sure why both w-full(width: 100%) and w-100vh(width: 100vh) are applied to media preview card. Sometimes, w-100vh are overriding w-full on my devices, making the picture misaligned.

Plus, I guess w-100vh is a typo? Is it supposed to be w-100vw?

Screenshot 2024-04-03 at 6 01 47 PM

Copy link

stackblitz bot commented Apr 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 5825810
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/660dfdd4732b520008508684

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 5825810
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/660dfdd4b6815a000893b486
😎 Deploy Preview https://deploy-preview-2751--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3
Copy link
Member

shuuji3 commented Apr 4, 2024

Thank you, I also encountered the same issue in the past.

To validate this fix, I'm trying several image posts but couldn't reproduce the issue yet. Could you share the example post that we can test or upload the sample image to elkdev account?

Maybe this was an accidental change by this commit: https://github.com/elk-zone/elk/pull/749/files#diff-91eeec335ef839760a2f6d9a82acc438b6fc0e796f1d603b65c38c89f7945672R40

I tested the image swipe on Google Chrome Android but the swipe works as expected. So I think w-100vh was not necessary and this change is fine.

@lazzzis
Copy link
Contributor Author

lazzzis commented Apr 5, 2024

Unfortunately, I am also unable to constantly repro this issue. The picture in the screenshot was randomly picked from the elkdev's timeline.

@userquin
Copy link
Member

userquin commented Apr 5, 2024

I can reproduce the problem using the second link in this issue #2752 (comment)

Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, understand. 👍

@patak-dev patak-dev added this pull request to the merge queue Apr 5, 2024
Merged via the queue into elk-zone:main with commit 1146dca Apr 5, 2024
14 checks passed
maybeanerd pushed a commit to maybeanerd/crab that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants