Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix regression where editor is expanded before composing #2787

Merged
merged 1 commit into from Apr 8, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Apr 8, 2024

fix #2781

Due to the regression, the editor has been expanded without condition. This change prevents the expansion by default and keeps the lower height until clicking.

Screenshots

Before fix

Before click

image

After click

image

After fix (Home)

Before click

Screenshot from 2024-04-09 00-12-54

After click

Screenshot from 2024-04-09 00-12-40

After fix (Thread reply)

Before click

Screenshot from 2024-04-09 00-12-09

After click

Screenshot from 2024-04-09 00-12-13

Copy link

stackblitz bot commented Apr 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit c93c695
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/66140c632979e90008a20cdb

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit c93c695
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/66140c637ed2380008fb1739
😎 Deploy Preview https://deploy-preview-2787--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patak-dev patak-dev added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit e0280ad Apr 8, 2024
17 checks passed
@patak-dev patak-dev deleted the shuuji3/fix/extra-space-in-editor branch April 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra space at top since 0.13.2
2 participants