fix(a11y): add aria-* entries to interface settings #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
|
This fix includes #2771 |
shuuji3
force-pushed
the
userquin/fix-a11y-interface-settings
branch
from
991ed4a
to
15d4966
Compare
shuuji3
force-pushed
the
userquin/fix-a11y-interface-settings
branch
from
15d4966
to
a1621fd
Compare
userquin
commented
Apr 13, 2024
|
I'll review the index.vue later (sending another PR), we should use some semantic tags like section moving the |
|
@shuuji3 if you are using mac, you can activate/deactivate VoiceOver with command+f5, check Introducing VoiceOver |
|
@userquin Thanks for the info. I'll give it a try as well as Android's similar feature 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.