Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): correct the spelling of Favorite in the US #2807

Merged
merged 1 commit into from Apr 13, 2024

Conversation

at-wr
Copy link
Contributor

@at-wr at-wr commented Apr 13, 2024

No description provided.

Copy link

stackblitz bot commented Apr 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit f8840ab
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/661a19d483ed020008463371

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit f8840ab
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/661a19d4e9eddf0008d496c8
😎 Deploy Preview https://deploy-preview-2807--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shuuji3 shuuji3 added this pull request to the merge queue Apr 13, 2024
Merged via the queue into elk-zone:main with commit 8e5a801 Apr 13, 2024
13 checks passed
@asmaloney
Copy link
Contributor

asmaloney commented Apr 14, 2024

Shouldn't this have been done in en-US.json?

(I'm not sure how the localization works here, but there's no en-CA.json for Canada, so with this change they get left with the USian spelling.)

Edit: I looked at the localization and see that en.json is supposed to be US English. I created a PR for Canadian English.

@shuuji3
Copy link
Member

shuuji3 commented Apr 15, 2024

@asmaloney This is probably due to how Elk sets up the localization. The current localization setup needs at least one main file as the default fallback (in case other languages/variants have not translated new strings yet), and Elk simply uses en.json as the default. When other languages/variants need to use different languages or spelling, each locale can override the default string as needed.

So the approach for en-CA.json in #2820 is totally correct. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants