feat: preview card for status links #339
Conversation
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ayoayco
changed the title
|
Just scrolled to the timeline a bit and I assume this is one example(?): https://deploy-preview-339--elk-zone.netlify.app/universeodon.com/@Sheril@mastodon.social/109457566567611895
|
|
Is this tackling the same issue as #161 ? |
i will check if this will also address video thumbnails @Shinigami92 |
Thank you! Still just draft. :) |
|
Messed up the git history. Will clean tomorrow. :) |
|
:p does this use the mastodon homesserver rendered og image for less ddos / more privacy? |
Yes we're only using what the Mastodon server gives us |
ayoayco
force-pushed
the
feat/fancy-card-for-links
branch
2 times, most recently
from
dbd8fba
to
389fabb
Compare
|
Looks awesome 🙌🏼 @ayoayco I see some images a bit blurry I don't know if we can do much here though. Looks like the image itself is small, no? Should we avoid stretching in these cases and maybe make the preview smaller? 🤔 Let's merge it though, and we can check for improvements in further PRs |
|
I think it is possible we are going to see inconsistencies, because instance servers generate these images, and I think some will generate lower quality ones to save resources. Yeah I think we can improve by not stretching when we see it is a small thumbnail. Will write an issue for this. @patak-dev |
| </StatusSpoiler> | ||
| <StatusCard | ||
| v-if="status.reblog" | ||
| :status="status.reblog" border="~ rounded" | ||
| :actions="false" | ||
| /> | ||
| </div> | ||
| <StatusLink v-if="status.card" :card="status.card" /> |
There was a problem hiding this comment.
I see a lot of warnings in the Console about this component and I can't find it.
There was a problem hiding this comment.
This should not be in the main branch by now. Can you pull the latest? @LittleSound
There was a problem hiding this comment.
feel free to correct me if this isn't the right solution @ayoayco
Implementation of Preview card for links included within status content.
Needs PR to masto.js: neet/masto.js#745
Fixes #335
Screenshots