Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: german translation #185

Closed
nephilim75 opened this issue Dec 20, 2016 · 21 comments
Closed

Feature: german translation #185

nephilim75 opened this issue Dec 20, 2016 · 21 comments
Assignees
@nephilim75
Labels
kind/enhancement
Milestone
1.2.5

Comments

@nephilim75
Copy link
Contributor

Hello

is it planned to have a german language package and documentation? I would like to contribute and I would like to offer the translation part.

Kind regards
//neph
@xezpeleta
Copy link
Contributor

Hi @nephilim75

Sure! we'd love to have the german translation! Recently another german user offered us to contribute:

https://groups.google.com/forum/#!topic/elkarbackup-users/s8Rkz3H-0MQ

But actually we don't have more news about that. If you're interested to contribute, here you have the instructions to follow:

  1. The file to be translated is BinovoElkarBackup.en.yml
  2. You can clone the project, create the new translated file BinovoElkarBackup.de.yml under the same translations directory, and finally send us a Pull Request
  3. If you are not familiar to GitHub workflow, don't worry, you can simply send us that file using this issue

Regarding the documentation, @parreitu is currently working on the english translation. It will be ready sooner rather than later. We'll be glad to have your contribution too!

Thank you very much

@xezpeleta xezpeleta changed the title contribution? Feature: german translation Dec 20, 2016
@nephilim75
Copy link
Contributor Author

Hi Xabi,

I started to translate the language pack. Let me know when the translation of documantation can start.

2 questions left.

  1. What do I need to do to implement the language pack into my system. I want to check my results by my own without publishing them until it is done completely.
  2. Is there an overview what text is shown on which page. It happens that the context is helpful for a useful translation.

Thank you in advance
//neph

@xezpeleta
Copy link
Contributor

What do I need to do to implement the language pack into my system. I want to check my results by my own without publishing them until it is done completely.

The easiest way could be to change an existing translation (for instance, the english one). Then you have to clean the cache and dump assets:

/usr/share/elkarbackup/app/console cache:clear --env=prod
/usr/share/elkarbackup/app/console assetic:dump --env=production

Once you do that, you'll see your own translated strings.

Is there an overview what text is shown on which page. It happens that the context is helpful for a useful translation.

No, sorry.

@nephilim75
Copy link
Contributor Author

nephilim75 commented Dec 21, 2016 •
edited

Thank you so much. It works as mentioned.

Where can I send messages to to discuss some translation related stuff. Shall this be discussed/posted here or somewhere else? There are some questions left where it is not clear to me what they are meaning. Before I use something stupid I need some assistance.

I have found some strings which are not listed in the language.yml file but shown on an EB page. Example is the policy area. If you edit the default policy you usually can edit the time and date the application takes the snapshots. In weekly area will shown english text but not the translated one.

example

Status of application translation: more than 85% done.

Kind regards
//neph

@xezpeleta
Copy link
Contributor

xezpeleta commented Dec 21, 2016 •
edited

Status of application translation: more than 85% done.

Wow! Good job! :D

I have found some strings which are not listed in the language.yml

You're right. Anyway, even if they aren't in the english yml the strings are prepared to be translated (I guess), so you can add them to your file:

'Day of week': 'translated string'
'Number of copies to keep': 'translated string'

Thanks

@nephilim75
Copy link
Contributor Author

'Number of copies to keep': 'translated string' is already in the file. For "during the day" tab it is ok as you can see beneath.

dd

But not for "daily, weekly, monthly and yearly" tab:

policies

Looks like the translation isn't being fetched. Any hint for me to get it fixed as well?

Kind regards
//neph

xezpeleta added a commit that referenced this issue Dec 22, 2016
@xezpeleta
Merge pull request #186 from elkarbackup/Translated-missing-string
ef0c3a9 
Translated missing string (fixes #185)
@xezpeleta
Copy link
Contributor

Ok, I've already fixed that. Will be solved in the next version.

@xezpeleta xezpeleta reopened this Dec 22, 2016
@nephilim75
Copy link
Contributor Author

Hej Xabi,

I need your assistance, again. There are 9 strings left where I don't got the meaning of them yet. Would you please help me to understand the meaning of them?

  • The application invoques the script using the user for backups.

  • (empty in client)

  • Can not have the retention count of the first backup level set to 1, and have a second backup level

  • du begin
    ('Client "%clientid%", Job "%jobid%" du begin.': 'Gerät "%clientid%", Aufgabe "%jobid%" du begin.')

  • du end
    ('Client "%clientid%", Job "%jobid%" du end.': 'Gerät "%clientid%", Aufgabe "%jobid%" du end.')

  • Error unlinking config file %filename%.

  • Error closing config file %filename%.

  • Error log for backup from job %joburl%

  • Policy %policyid% has no active retains

Thank you in advance

Kind regards
//neph

@xezpeleta
Copy link
Contributor

xezpeleta commented Dec 22, 2016 •
edited

The application invokes the script using the user for backups.

Context: scripts (help message).

UPDATED: It means that the script will be executed as elkarbackup user

(empty in client)

Context: scripts (help message), environment variables.

This envar will be empty when the script is running as pre/post client script.

Can not have the retention count of the first backup level set to 1, and have a second backup level

Context: policies, warning message

I haven't found another better way to explain it. It's a warning text. The policy designer form will show you this message when you choose 1 for the first backup retention level and you have a second backup level. You should increase that retention level, or remove the second backup level.

du begin
('Client "%clientid%", Job "%jobid%" du begin.': 'Gerät "%clientid%", Aufgabe "%jobid%" du begin.')
du end
('Client "%clientid%", Job "%jobid%" du end.': 'Gerät "%clientid%", Aufgabe "%jobid%" du end.')

Context: logs
Don't worry, you can keep these messages as they were (in english).

Error unlinking config file %filename%.
Error closing config file %filename%.
Error log for backup from job %joburl%
Policy %policyid% has no active retains

Context: logs (error messages)
Same as above. I suggest you not to translate these messages. Can be useful to keep them in english to debug purposes.

Thanks

@nephilim75
Copy link
Contributor Author

Hello Xabi

would you please assist me to get the following more clear?

Even hourly calls only rotate the directories, without even connecting to the client. This ensures that the snapshots are consistent with the cost of an additional snapshot used only for syncing.

Thank you so much

Kind regards
//neph

@parreitu
Copy link
Contributor

parreitu commented Dec 30, 2016 via email

@xezpeleta
Copy link
Contributor

xezpeleta commented Dec 31, 2016 •
edited

@nephilim75 You have it explained much better here:

I run rsnapshot for the first time, but nothing happens. Why?

rsnapshot does two major things - actual backup (with rsync) and rotation (moving snapshots around). Before it can do rotations, it needs to have at least one actual backup. So you need to understand which rsnapshot invocation will make an actual backup.

For example, if you have sync_first enabled, then you need to run rsnapshot sync (which makes a backup) before you can do a rotation like rsnapshot hourly or rsnapshot daily. With sync_first enabled, all intervals (hourly, daily, etc) just do rotation.

If you do not have sync_first (it is disabled by default), then the backup is made by the lowest interval (that is, the first one that you listed in your rsnapshot.conf). The other (higher) intervals do rotation. For example, if you have intervals hourly, daily, weekly and monthly, then you need to run rsnapshot hourly to do a backup before the other intervals (daily, weekly and monthly which do rotations) will do anything.

In fact, you need a complete set of hourly backups before a rsnapshot daily will do anything. Similarly, you need a complete set of daily backups (usually 7) before rsnapshot weekly will do anything.

http://rsnapshot.org/faq.html

@parreitu
Copy link
Contributor

parreitu commented Jan 3, 2017 via email

@nephilim75
Copy link
Contributor Author

Hej guys

happy new year to all of you.

I am testing right now and I believe I am almost finished. But there is just one thing left.

Sorry to bother you again. Please help me to get this warning message more clear:

Can not have the retention count of the first backup level set to 1, and have a second backup level

When does it coming up? Where does it coming up in application? What do I need to do to create an issue that brings that message up?

Once I got language pack finished I will start to translate the documentation.

Kind regards
//neph

@xezpeleta
Copy link
Contributor

Hi @nephilim75

I'm glad your translation is almost finished.

'Can not have the retention count of the first backup level set to 1, and have a second backup level'

That's the Rsnapshot behavior:
http://www.backupcentral.com/forum/18/226280

The message will be shown when you have a policy where the first backup level (i.e. hourly) has a retention level to 1, and you want to set up a second backup level (i.e. daily).

Due to the Rsnapshot rotation behavior, if you want to add a daily backup level, you need to increase the retention under hourly (i.e. from 1 to 2).

Anyway, do not worry. It's not necessary to translate all the strings. I consider a partial translation it's better than nothing. So, if you want you can send us your translation file as it is.

Thanks again

@parreitu
Copy link
Contributor

parreitu commented Jan 12, 2017 via email

@nephilim75
Copy link
Contributor Author

nephilim75 commented Jan 12, 2017 •
edited

Hello

it's done. Find the file attached.

I found further minor translation issues (similar to here) but I will wait to document/report them until next version is released.

Kind regards
//neph
BinovoElkarBackup.de.yml.zip

@xezpeleta
Copy link
Contributor

Great!! Thanks. I'm going to add it and release a new version. I'll keep you updated.

@xezpeleta xezpeleta added this to the 1.2.5 milestone Jan 13, 2017
@xezpeleta
Copy link
Contributor

Hi @nephilim75

I've just created a new version with your contribution: https://github.com/elkarbackup/elkarbackup/releases/tag/v1.2.5

I will upload it to the debian/ubuntu repo during the next days

Thanks again

@xezpeleta
Copy link
Contributor

@nephilim75 I've just uploaded the new release to the Ubuntu/Debian repo.

You can upgrade to the new version now using apt-get update && apt-get upgrade

@nephilim75
Copy link
Contributor Author

This was working perfectly fine. Thank you so much for all your efforts.

I found more minor translation issues. I will send a pull request once I have reviewed everything. ;-)

Kind regards
//neph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nephilim75 nephilim75

Labels
kind/enhancement
Projects
None yet
Milestone
1.2.5
Development

No branches or pull requests
3 participants
@xezpeleta @parreitu @nephilim75