Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previewing from quick reply breaks a bit of things #1400

Closed
emanuele45 opened this issue Feb 19, 2014 · 5 comments
Closed

Previewing from quick reply breaks a bit of things #1400

emanuele45 opened this issue Feb 19, 2014 · 5 comments

Comments

@emanuele45
Copy link
Contributor

Certain bbcode is broken when going from quick reply (plain text) to the post page using the preview button.
For example tabs are lost in [code] blocks (ie. past a block of code with tabs in quick reply, click preview => tabs gone), the equal parameter is lost in quote:

[quote=someone]blabla[/quote]

becomes:

[quote]blabla[/quote]
@emanuele45 emanuele45 added this to the 1.0 Final milestone Feb 19, 2014
@emanuele45
Copy link
Contributor Author

Both are due to the editor.

  • code: when SCEditor "copies" the content of the original textarea to the new one, it considers the tabs as they are html and just "ignores" them
  • quote: SCEditor doesn't know it and strip the content.

@emanuele45
Copy link
Contributor Author

Another bit:

[code=this is some text]blabla[/code]

is converted to:

[code="this is some text"]blabla[/code]

Spuds added a commit to Spuds/Elkarte that referenced this issue Mar 3, 2014
Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
Copy link
Contributor

Spuds commented Mar 3, 2014

The code quote issue should be fixed here: Spuds@165dba7 also an extra leading space was being added in when toggling so thats fixed (although the toggle wiz formatting looks like crap for some reason)

Spuds added a commit to Spuds/Elkarte that referenced this issue Mar 3, 2014
Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
Copy link
Contributor

Spuds commented Mar 3, 2014

This Spuds@455414e should address the [quote=someone]blabla[/quote] issue ... it will add author=someone when you toggle or save from text mode (should)

@emanuele45
Copy link
Contributor Author

This is fixed with emanuele45@2f985f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants