Undefined index: body_fail

[emanuele45]

@Spuds that's for you... 😭

I was trying to test the bounce emails, so I took a gmail account I have, and added the configs to my localhost install of elk.
Then I enabled the mail queue.
I sent a PM to a member with a broken email.
Then I went to ?action=admin;area=mailqueue;sa=browse and clicked on "Send mail queue now".

The result is:

Notice: Undefined index: body_fail

    reduceMailQueue() in /.../Dialogo/sources/subs/Mail.subs.php at line 1390
    action_clear() in /.../Dialogo/sources/admin/ManageMail.controller.php at line 412
    dispatch() in /.../Dialogo/sources/subs/Action.class.php at line 182
    action_index() in /.../Dialogo/sources/admin/ManageMail.controller.php at line 92
    callMenu() in /.../Dialogo/sources/subs/Menu.subs.php at line 385
    action_index() in /.../Dialogo/sources/admin/Admin.controller.php at line 579
    dispatch() in /.../Dialogo/sources/SiteDispatcher.class.php at line 264
    elk_main() in /index.php_11 at line 237
    require_once() in /index.php_11 at line 166
    () in /index.php at line 23

Notice: Undefined index: body_fail in /.../Dialogo/sources/subs/Mail.subs.php on line 1390 Call Stack: 0.0001 254616 1. {main}() /home/emanuele/webserver/htdocs/beta_21/index.php:0 0.0005 312712 2. require_once('/home/emanuele/webserver/htdocs/beta_21/index.php_11') /home/emanuele/webserver/htdocs/beta_21/index.php:23 0.0242 3533632 3. elk_main() /home/emanuele/webserver/htdocs/beta_21/index.php_11:166 0.0420 4361656 4. Site_Dispatcher->dispatch() /home/emanuele/webserver/htdocs/beta_21/index.php_11:237 0.0453 4777632 5. Admin_Controller->action_index() /.../Dialogo/sources/SiteDispatcher.class.php:264 0.0540 5557616 6. callMenu() /.../Dialogo/sources/admin/Admin.controller.php:579 0.0546 5644432 7. ManageMail_Controller->action_index() /.../Dialogo/sources/subs/Menu.subs.php:385 0.0570 5805176 8. Action->dispatch() /.../Dialogo/sources/admin/ManageMail.controller.php:92 0.0571 5805576 9. ManageMail_Controller->action_clear() /.../Dialogo/sources/subs/Action.class.php:182 0.0592 6089888 10. reduceMailQueue() /.../Dialogo/sources/admin/ManageMail.controller.php:412
Error: The database value you're trying to insert does not exist: body(Mail.subs.php-1098)

    trigger_error() in /.../Dialogo/sources/database/Db-abstract.class.php at line 306
    error_backtrace() in /.../Dialogo/sources/database/Db-abstract.class.php at line 306
    replacement__callback() in /.../Dialogo/sources/database/Db-abstract.class.php at line 92
    preg_replace_callback()
    quote() in /.../Dialogo/sources/database/Db-abstract.class.php at line 191
    insert() in /.../Dialogo/sources/database/Db-mysql.class.php at line 720
    updateFailedQueue() in /.../Dialogo/sources/subs/Mail.subs.php at line 1098
    reduceMailQueue() in /.../Dialogo/sources/subs/Mail.subs.php at line 1404
    action_clear() in /.../Dialogo/sources/admin/ManageMail.controller.php at line 412
    dispatch() in /.../Dialogo/sources/subs/Action.class.php at line 182
    action_index() in /.../Dialogo/sources/admin/ManageMail.controller.php at line 92
    callMenu() in /.../Dialogo/sources/subs/Menu.subs.php at line 385
    action_index() in /.../Dialogo/sources/admin/Admin.controller.php at line 579
    dispatch() in /.../Dialogo/sources/SiteDispatcher.class.php at line 264
    elk_main() in /index.php_11 at line 237
    require_once() in /index.php_11 at line 166
    () in /index.php at line 23

The issue seems to be that 'body_fail' is set only at https://github.com/elkarte/Elkarte/blob/development/sources/subs/Mail.subs.php#L1364 so only when using send_mail and the mailing list is enabled.

What would you suggest for the fix? 👼

ETA: actually, 'body_fail' is used only in these two places (when it's set and when it's used) and is set to be equal to 'body'... can we just remove it and use 'body' instead?

[emanuele45]

@Spuds any opinion on that? 👼

[Spuds]

Sorry, I promise to take a look as soon as I'm done breaking things with _req Plus I still need to fix beSocial and want to use the poor mans lightbox for the attachment zoom ... Argh ! Oh I think the search api should have standard topic remove, post remove, etc methods ... just seems tidy that way ... Argh to much stuff in my head !

[emanuele45]

Argh to much stuff in my head !

Track it!! :P

[joshuaadickerson]

That is a hard one to test for me, but does that commit fix the problem?

[Spuds]

Changed milestone to 1.0.7 as the error exists there when re adding a mail back to the queue after a sendmail failure.