Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Count #3376

Closed
Spuds opened this issue Dec 20, 2019 · 3 comments
Closed

Mention Count #3376

Spuds opened this issue Dec 20, 2019 · 3 comments

Comments

@Spuds
Copy link
Contributor

Spuds commented Dec 20, 2019

Currently the menu notification count indicator can get out of sync with what the member actually has.

This occurs when a message is removed (if the message had a like, quote, mention) ... So like a member post and then delete the post, the notification indicator will stay at 1 until you go into and then exit notification area.

The log_mentions table is updated when the message is removed, but I don't see a quick maintenance task that does an updateMemberData. Just an annoyance really .... We probably need to search the mentions_log table for entries against that message and then update those found member_ids with the new lowered count.

@Spuds Spuds added this to the 1.1.7 milestone Dec 20, 2019
@Spuds
Copy link
Contributor Author

Spuds commented Dec 20, 2019

@emanuele45 kind of the same question here as well ... in MessageDelete.class.php when a message is removed we have the // Remove the mentions! query when it also exludes the quotedmem and I'm not sure why, I'm thinking I'm missing understanding something 🐵

@emanuele45
Copy link
Contributor

And Topics.subs.php I guess.
I feel kind of the same answer...

@Spuds
Copy link
Contributor Author

Spuds commented Dec 20, 2019

Oh yeah 🤦‍♂ the topic deletion stuff as well.

Spuds added a commit to Spuds/Elkarte that referenced this issue Dec 21, 2019
@Spuds Spuds closed this as completed Jan 7, 2020
Spuds added a commit to Spuds/Elkarte that referenced this issue Jan 7, 2020
Spuds added a commit to Spuds/Elkarte that referenced this issue Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants