Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title "crowds" border in catbg / cat_bar in admin panel #618

Closed
Spuds opened this issue Jul 6, 2013 · 3 comments
Closed

Title "crowds" border in catbg / cat_bar in admin panel #618

Spuds opened this issue Jul 6, 2013 · 3 comments

Comments

@Spuds
Copy link
Contributor

Spuds commented Jul 6, 2013

<div class="cat_bar">
   <h3 class="catbg"> Wombats</h3>
</div>

in FF 22 at least, this markup in the admin panel leaves the text with no left side padding so its seems to crowd the border a tad. May be whats intended but just in case making mention of it.

@StealthWombat
Copy link
Contributor

No it's just something that hasn't been touched yet. Looks like crap. The plan is to drop the div anyway, and use just an h2 or h3 with a class name that makes sense (coz catbg sux). I fancy class names like category_header and subsection_header. Stuff that anyone can see and immediately know what it's for.

@Spuds
Copy link
Contributor Author

Spuds commented Jul 7, 2013

Sounds good (the class name change to something less cryptic) ... past that if you can nuke the div thats cool!

@StealthWombat
Copy link
Contributor

I can nuke those divs everywhere. I'm on a mission to nuke divs, and those ones were only ever included to allow roundy image corners in IE6, 7 and 8. No longer required or desired.

norv pushed a commit to norv/elkarte that referenced this issue Jul 19, 2013
…elkarte#641, $646, elkarte#662, elkarte#664, elkarte#668, elkarte#670.

=================================================
sources/Subs.php
Took the forced styling out of the me tag array. People can play with it in the css.
Re-wrote the main menu array as per topic at Elk.
-------------------------------------------------
sources/controllers/Memberlist.controller.php
Removed redundant th classes. Added some that will be needed.
-------------------------------------------------
sources/admin/ManageBans.php
sources/admin/ManageCalendar.php
sources/admin/ManageMail.php
sources/admin/ManageMembergroups.php
sources/admin/ManageSmileys.php

Changed a button class to one of the new classes. Removed some inline CSS.
-------------------------------------------------
sources/admin/Modlog.php
Removed redundant th classes.
-------------------------------------------------
sources/admin/Packages.php
Changed a button class to one of the new classes. Removed some inline CSS.
=================================================
themes/default/css
index.css and index_light.css have had a lot of changes. Too many to list. We haz shiny new theme. :D
admin.css had a few smallish tweaks (some temporary, some not).
rtl.css and install.css just had some old class names changed to new ones.
-------------------------------------------------
themes/default/languages
Admin.english.php just had one letter changed (didn't need a captial).

index.english.php had some new strings added, some old ones changed, and a bit of re-organising.
-------------------------------------------------
themes/default/scripts
post.js - Fixed some old markup, to match the new template and css.
Added a coment about a stray line break. This could be the cause of a minor bug with SCE and Firefox.
Didn't remove it because not sure why it is there.
-------------------------------------------------
themes/default
Admin.template.php - Minor class updates, and fix for elkarte#617
BoardIndex.template.php - Some markup clean up, and moved news fader to index.template.php.
Calendar.template.php - New markup and classes stuff.
--------
Display.template.php, ModerationCenter.template.php, PersonalMessage.template.php,
Profile.template.php, ProfileInfo.template.php, Recent.template.php, Search.template.php -

Bug fixes for markup (mostly quickbuttons, some re-ordering for consistency across templates,
includes fix for elkarte#662 in Display, and for elkarte#646 in Recent).
--------
GenericMenu.template.php - Fix for elkarte#617.
index.template.php - Markup revisions for more sanity (very clean now). Addition of news fader. Fix for elkarte#640.
BadBehavior.template.php, Errors.template.php, GenericControls.template.php,
ManageMembergroups.template.php, ManageNews.template.php, ManagePermissions.template.php,
Memberlist.template.php, ModerationCenter.template.php,
Post.template.php, Who.template.php - Minor class updates.

Themes.template.php - Finishing touches for elkarte#645 markup.

msg_alert_none is now topic_alert_none.
topic_alert_none, the second one..
Back with some $txt strings... Blame Ant :P
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>

Signed-off-by: Norv <a.w.norv@gmail.com>
@Spuds Spuds closed this as completed Jul 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants