Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuff to deprecate: cat_bar, catbg, title_bar, titlebg, first_th, last_th, th class="centertext". #624

Closed
StealthWombat opened this issue Jul 8, 2013 · 4 comments
Milestone

Comments

@StealthWombat
Copy link
Contributor

I'm making a start on these. General plan goes like this:

All of the old h3/h4 header bars are getting new, sensible class names like category_header. Will use two or three classes of header, to get all areas looking good. Play that by ear. They will also have the old surrounding divs (cat_bar and title_bar) stripped away, so it's just plain h*.

Last but not least, all will be checked for proper page hierarchy. So (unlike SMF) we'll start with an h2 instead of an h3 (h1 being the main forum banner up top) then go down through h3, h4, h5 and, if required, h6.

Real document outlining! It'll be a miracle. 😀

I'm killing the catbg class on table headers too, and just going with a table_head class for those tr's. The odd titlebg rows will get turned into something else.

First_th and last_th can just be removed from anywhere. Anyone who wants special styling on those cells can use CSS3 child stuffz.

th class="centertext" can be removed from anywhere too. Browsers always render th with centre-aligned text by default anyway, so having a class to do the same thing is pointless. All we need to keep is the lefttext and righttext classes in th elements, wherever we want those.

Should save a pile of bloat by the time it's sorted, and be less confusing.

@emanuele45
Copy link
Contributor

There is still plenty of these.

Should they just be dropped mercilessly or there is to pay some attention? 😇

@Spuds
Copy link
Contributor

Spuds commented Sep 24, 2013

Only the wombat knows ... @StealthWombat ?

@eurich
Copy link
Member

eurich commented Oct 11, 2013

just for the record: th=centertext is needed, at least for Chrome / W7..

emanuele45 added a commit to emanuele45/Dialogo that referenced this issue Nov 9, 2013
Signed-off-by: emanuele <emanuele45@gmail.com>
@eurich
Copy link
Member

eurich commented Nov 22, 2013

Closing this one. I think we're almost done with the initial listed classes.. There may be more but we can track those in a new issue report..

@eurich eurich closed this as completed Nov 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants