Structuring #1295
Merged
Structuring #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
… one index of $context - seems more organized Signed-off-by: emanuele <emanuele45@gmail.com>
…ul (it was always hooking index_action) Signed-off-by: emanuele <emanuele45@gmail.com>
… attachments templates Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
|
looks 👍 to me (is the optimized loading a dupe commit?) .... anyway good for B2 (I think so)? If so lets merge so I can get it on the site for some live testing. |
|
Oppps, missed this comment somehow. Mean while, with the files modified by @emanuele45 are helping a lot. All suggestions/advises are most welcomed https://github.com/siddhartha-gupta/Elkarte/commit/add921f95c2a7929b36eea2565019ef101c3e431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bit or restructuring of templates.
I started in Post page moving all the options related to attachments (at least the ones I found) to a single index $context['attachments'] so that everything is there.
Then I also split (again) the Post page template to allow override the way attachments are presented/handled. This should help @siddhartha-gupta in replacing the upload system (hint: you can use the hook
integrate_post_afteryou won't find it in the code, but it is provided but the Dispatcher, see emanuele45@88787e0 based on the name of the controller invoked <= note to self: something to document!!)