Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

couple of things related to errors #181

Merged
merged 1 commit into from Feb 27, 2013
Merged

Conversation

emanuele45
Copy link
Contributor

Including #169

…rror just to have the proper template...

Signed-off-by: emanuele <emanuele45@gmail.com>
emanuele45 added a commit that referenced this pull request Feb 27, 2013
couple of things related to errors
@emanuele45 emanuele45 merged commit 5b32821 into elkarte:master Feb 27, 2013
@norv
Copy link
Contributor

norv commented Feb 27, 2013

So this also fixes #169 ?

I have also added the missing require directly when I moved the code to the editor (ab6fd51#L1R645). If it's useless in all use scenarios, we can remove that require.

However if we remove the require: I wonder if now, when people can and will use of the editor, and may add live_errors option freely to it, their code will have Errors loaded... because I guess one can just reuse the box.

@emanuele45
Copy link
Contributor Author

The language error is loaded by ->prepareErrors, what I'm not sure is if it makes sense to load Errors.language just for a couple of strings that may or may not be used...maybe move that couple of strings to Post.language?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants