I know I was told it works as is, but I just don't see how #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spuds <spuds@spudsdesign.com>
|
Err.. Magic? Seems more likely than me testing wrong branch/commit or no.clue.what.! Thanks for the fix! |
norv
added a commit
that referenced
this pull request
Apr 2, 2013
I know I was told it works as is, but I just don't see how
|
LOL ... thank goodness it was not one of the serious ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so here is my proposal so the class returns the items that the xml function needs ($context etc) .... Could also redo the xml function to use ->settings(), not sure what the plan is but till then ...
Signed-off-by: Spuds spuds@spudsdesign.com