New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic urls #3246
Merged
Merged
Semantic urls #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing on the first URL I found
…ession data and alike can be added easily and consistently
…xample when we have to redirectExit, so added a method to UrlGenerator to deal with that specifically
…f consecutive separators
…rollers that are more likely to be facing users
…l.controller.php to getUrl
…he to a proper function stored in Calendar.subs.php - The cost is that the file has to be included, but at least it's much easier to read.
…ng URLs in the templates
…admin wants to use
…dSettings to pick the correct one
will hopefully make it use the current version (i.e. at the time of writing 7.1) - fixes elkarte#3247
emanuele45
force-pushed
the
semantic_urls
branch
from
October 28, 2018 14:35
25a5d2e
to
5c272e6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a first attempt.
Still many things missing, but at least it should be the scaffold.