Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic urls #3246

Merged
merged 35 commits into from Oct 28, 2018

Conversation

2 participants
@emanuele45
Copy link
Contributor

commented Oct 27, 2018

That's a first attempt.
Still many things missing, but at least it should be the scaffold.

emanuele45 added some commits Aug 4, 2018

Added support for replacements in the UrlGenerator class, this way, s…
…ession data and alike can be added easily and consistently
Sometimes we only want to generate the "query" part of the URL, for e…
…xample when we have to redirectExit, so added a method to UrlGenerator to deal with that specifically
Some more conversions of manual URL writing to getUrl - moved to cont…
…rollers that are more likely to be facing users
Extract the post_retri_eval function from the string saved in the cac…
…he to a proper function stored in Calendar.subs.php - The cost is that the file has to be included, but at least it's much easier to read.

@emanuele45 emanuele45 added this to the 2.0 milestone Oct 27, 2018

The tests were failing because travis sudo php was version 5.5, this
will hopefully make it use the current version (i.e. at the time of
writing 7.1) - fixes #3247

@emanuele45 emanuele45 force-pushed the emanuele45:semantic_urls branch from 25a5d2e to 5c272e6 Oct 28, 2018

@Spuds Spuds merged commit 2b7ff41 into elkarte:development Oct 28, 2018

2 of 3 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Scrutinizer 14 new issues, 41 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Spuds Spuds added this to Done in Semantic URL via automation Oct 28, 2018

@emanuele45 emanuele45 referenced this pull request Oct 28, 2018

Closed

Friendly URLs #2167

@emanuele45 emanuele45 deleted the emanuele45:semantic_urls branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.