Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additonal areas of cleanup #3762

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Additonal areas of cleanup #3762

merged 5 commits into from
Mar 1, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Mar 1, 2024

Quick pass through themes and install areas, mostly to reverse !empty and !isset sillyness

@Spuds Spuds added this to the 2.0 milestone Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 43.41463% with 116 lines in your changes are missing coverage. Please review.

Project coverage is 33.30%. Comparing base (f8b62c0) to head (d68f678).
Report is 1 commits behind head on development.

Files Patch % Lines
themes/default/ProfileOptions.template.php 27.77% 39 Missing ⚠️
themes/default/Admin.template.php 17.39% 19 Missing ⚠️
themes/default/GenericMessages.template.php 6.25% 15 Missing ⚠️
themes/default/GenericMenu.template.php 42.85% 8 Missing ⚠️
themes/default/Register.template.php 0.00% 8 Missing ⚠️
themes/default/Xml.template.php 0.00% 8 Missing ⚠️
themes/default/MessageIndex.template.php 42.85% 4 Missing ⚠️
themes/default/Post.template.php 55.55% 4 Missing ⚠️
themes/default/Display.template.php 86.66% 2 Missing ⚠️
themes/default/ManageMembers.template.php 50.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3762      +/-   ##
=================================================
- Coverage          34.38%   33.30%   -1.08%     
  Complexity         16512    16512              
=================================================
  Files                430      429       -1     
  Lines              84040    83467     -573     
=================================================
- Hits               28893    27800    -1093     
- Misses             55147    55667     +520     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spuds Spuds merged commit 32a388a into elkarte:development Mar 1, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant