Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS updates and directory structure #3766

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Mar 5, 2024

Removed as much jquery code from the editor plugins as possible
Add new serialize url encode function, remove jsonstring. Helps with moving from $.ajax to fetch api
Added scripts/editor and scripts/ext directories to clean up the scripts folder
Updated all of those calls

! remove as much jquery code from the editor plugins as possible
! add new serialize url encode function, remove jsonstring
@Spuds Spuds added this to the 2.0 milestone Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 33.08%. Comparing base (279a9df) to head (b338360).
Report is 1 commits behind head on development.

Files Patch % Lines
sources/subs/Editor.subs.php 62.50% 3 Missing ⚠️
sources/ElkArte/Controller/Register.php 33.33% 2 Missing ⚠️
sources/ElkArte/Controller/Reminder.php 0.00% 2 Missing ⚠️
sources/ElkArte/EmojiIntegrate.php 0.00% 2 Missing ⚠️
sources/ElkArte/Notifications/UserNotification.php 0.00% 2 Missing ⚠️
sources/ElkArte/Themes/Javascript.php 50.00% 2 Missing ⚠️
...ces/ElkArte/AdminController/ManageRegistration.php 0.00% 1 Missing ⚠️
sources/ElkArte/Controller/Auth.php 75.00% 1 Missing ⚠️
sources/ElkArte/Controller/Stats.php 0.00% 1 Missing ⚠️
sources/ElkArte/Modules/Drafts/Display.php 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3766      +/-   ##
=================================================
- Coverage          34.30%   33.08%   -1.22%     
+ Complexity         16555    16552       -3     
=================================================
  Files                432      431       -1     
  Lines              84239    83650     -589     
=================================================
- Hits               28895    27679    -1216     
- Misses             55344    55971     +627     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spuds Spuds merged commit b1bef70 into elkarte:development Mar 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant