Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA App #3775

Merged
merged 10 commits into from
Mar 30, 2024
Merged

PWA App #3775

merged 10 commits into from
Mar 30, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Mar 28, 2024

All of the initial items to provide a basic functional PWA .. includes manifest generation and new icons

@Spuds Spuds added this to the 2.0 milestone Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 50.50000% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 32.90%. Comparing base (9552e90) to head (6d9ab46).
Report is 1 commits behind head on development.

Files Patch % Lines
sources/ElkArte/AdminController/ManageFeatures.php 0.00% 64 Missing ⚠️
sources/ElkArte/Themes/Theme.php 31.25% 22 Missing ⚠️
sources/Subs.php 22.22% 7 Missing ⚠️
sources/ElkArte/Controller/Offline.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3775      +/-   ##
=================================================
+ Coverage          32.81%   32.90%   +0.09%     
- Complexity         12889    12925      +36     
=================================================
  Files                286      288       +2     
  Lines              62419    62607     +188     
=================================================
+ Hits               20484    20603     +119     
- Misses             41935    42004      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spuds Spuds force-pushed the PWA branch 6 times, most recently from 3482da3 to 09c2357 Compare March 28, 2024 22:41
@Spuds Spuds force-pushed the PWA branch 7 times, most recently from c0016c3 to 82cd0f6 Compare March 30, 2024 13:20
@Spuds Spuds merged commit da87155 into elkarte:development Mar 30, 2024
10 checks passed
@Spuds Spuds deleted the PWA branch March 30, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant