Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache #3801

Merged
merged 15 commits into from
Jun 4, 2024
Merged

Cache #3801

merged 15 commits into from
Jun 4, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Jun 1, 2024

Adds redis cache support (2) ways

One uses the phpredis pecl extension
One uses the predis\predis php library

Its up the the admin (site and server) how they want to install those. pecl is straight foward, and in the PR the predis would have to be placed in the ext directory. I think moving to full composer vendor directory support is the direction we should move and drop the ext directory or leave it there just for addons not the core.

Still need to add tests

@Spuds Spuds added this to the 2.0 milestone Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.59%. Comparing base (da9ee2e) to head (adfb03c).
Report is 1 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3801      +/-   ##
=================================================
+ Coverage          43.49%   43.59%   +0.10%     
- Complexity         13955    14045      +90     
=================================================
  Files                348      350       +2     
  Lines              74966    75199     +233     
=================================================
+ Hits               32606    32785     +179     
- Misses             42360    42414      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spuds Spuds merged commit 8433eb1 into elkarte:development Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants