attachments hash (Josh) #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get rid of the $new parameter in getAttachmentFilename() Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
…of this query. If $file_hash is empty, it is because it isn't set in the database. Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
Spuds
added a commit
to Spuds/Elkarte
that referenced
this pull request
Nov 2, 2013
… Subs.php ! use the filehash in the call, not the legacy call? ! parts of elkarte#403 Signed-off-by: Spuds <spuds@spudsdesign.com>
Spuds
pushed a commit
to Spuds/Elkarte
that referenced
this pull request
Nov 2, 2013
! part of ref : elkarte#403 Signed-off-by: Spuds <spuds@spudsdesign.com>
Merged
|
As much of this as we can do has been done ... so I'm closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked and rebased the attachments part of #397. Open for review.