Misc refactoring #445
Merged
Misc refactoring #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
… topicsList() (parallel to getBoardsList()) Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
…r message. Not sure if this is so useful.Just need to clear the view of the action_post() code.. Signed-off-by: Norv <a.w.norv@gmail.com>
…x anyway? MessageIndex doesn't even use it) Signed-off-by: Norv <a.w.norv@gmail.com>
…mall function, which can probably be improved. Commented out log_topics part of markBoardsRead(), experimentally.. because I don't see why that update should happen when you mark boards as read... Put it back if it has consequences. Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
| { | ||
| // Limit them to $modSettings['preview_characters'] characters | ||
| $row['first_body'] = strip_tags(strtr(parse_bbc($row['first_body'], $row['first_smileys'], $row['id_first_msg']), array('<br />' => ' '))); | ||
| if ($smcFunc['strlen']($row['first_body']) > $modSettings['preview_characters']) |
There was a problem hiding this comment.
Probably you just missed this one, I'd prefer Util::strlen() instead of $smcFunc['strlen'], for the sake of consistency..
There was a problem hiding this comment.
fixed norv@23dfd97
/methinks another batch of all replacements for utility functions is waiting for us. :)
Signed-off-by: Norv <a.w.norv@gmail.com>
Refactor poll information retrieval in Display controller. Attempt slightly consistency in subs function names.. Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
…er $resetTopics() to switch it on or off if needed. Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
…th the existing, i.e. messagePointer() and next/previous following topicPointer() and related. Signed-off-by: Norv <a.w.norv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A batch of refactoring, from more parts of the code. It needs pretty badly another pair of eyes, 'cause mine are don't see anything anymore.. 🔮